Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3347)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm

Issue 12224052: Alternate NTP: Fix bug where shadow is not removed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm b/chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm
index 8a0d1df8a89413d7425efa1b203f62ec6094327a..356178d7bc8f3172490f75a2292cb3e59249b54d 100644
--- a/chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm
@@ -29,12 +29,15 @@ void InstantPreviewControllerMac::PreviewStateChanged(
BOOL drawDropShadow = !model.mode().is_ntp() &&
!(model.height() == 100 &&
model.height_units() == INSTANT_SIZE_PERCENT);
- [preview_ showPreview:model.GetPreviewContents()
- height:model.height()
- heightUnits:model.height_units()
- drawDropShadow:drawDropShadow];
+ [preview_ setPreview:model.GetPreviewContents()
+ height:model.height()
+ heightUnits:model.height_units()
+ drawDropShadow:drawDropShadow];
} else {
- [preview_ hidePreview];
+ [preview_ setPreview:NULL
+ height:0
+ heightUnits:INSTANT_SIZE_PIXELS
+ drawDropShadow:NO];
}
browser_->MaybeUpdateBookmarkBarStateForInstantPreview(model.mode());
[window_ updateBookmarkBarStateForInstantPreview];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698