Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/trusted/validator_arm/armv7.table

Issue 12223046: Use generated actual decoders for ARM table: (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/validator_arm/build.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/armv7.table
===================================================================
--- src/trusted/validator_arm/armv7.table (revision 10736)
+++ src/trusted/validator_arm/armv7.table (working copy)
@@ -1780,7 +1780,7 @@
{ cond(31:28), W(21), Rn(19:16), register_list(15:0) }
registers := RegisterList(register_list); wback := W=1;
base := Rn;
- small_imm_base_wb := true;
+ small_imm_base_wb := wback;
safety := Rn == Pc | NumGPRs(registers) < 1 => UNPREDICTABLE;
*LdRnRegs *RnRegs
baseline := LoadRegisterList;
@@ -1803,7 +1803,7 @@
defs := {Pc};
uses := {Pc};
relative := true;
- relative_offset := imm32;
+ relative_offset := imm32 + 8; # r15 is 8 bytes ahead of instruction address.
JF 2013/02/11 19:40:38 I'd change the comment to be the same as other pla
Karl 2013/02/11 22:12:43 Done.
safety := true => MAY_BE_SAFE;
*BranchLink *Branch
defs := {Pc, Lr};
« no previous file with comments | « no previous file | src/trusted/validator_arm/build.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698