Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1222243005: Fix unused variables errors in cc/. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
nduca, vmpstr
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@nacl_private_fields
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused variables errors in cc/. This needed in order to use "= delete" for DISALLOW_COPY_AND_ASSIGN. BUG=447445 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0aa02af8e3030bfb52c6c905d53f18643df2c68c Cr-Commit-Position: refs/heads/master@{#337484}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M cc/animation/animation_host.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/animation/animation_host.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M cc/animation/animation_host_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/animation/animation_timeline_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/layers/render_surface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1221333008 Patch 1

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-06 19:33:21 UTC) #2
vmpstr
https://codereview.chromium.org/1222243005/diff/1/cc/animation/animation_host.cc File cc/animation/animation_host.cc (right): https://codereview.chromium.org/1222243005/diff/1/cc/animation/animation_host.cc#newcode23 cc/animation/animation_host.cc:23: mutator_host_client_() { nit: Can you put nullptr in here ...
5 years, 5 months ago (2015-07-06 20:00:41 UTC) #4
mlamouri (slow - plz ping)
PTAL https://codereview.chromium.org/1222243005/diff/1/cc/animation/animation_host.cc File cc/animation/animation_host.cc (right): https://codereview.chromium.org/1222243005/diff/1/cc/animation/animation_host.cc#newcode23 cc/animation/animation_host.cc:23: mutator_host_client_() { On 2015/07/06 at 20:00:41, vmpstr wrote: ...
5 years, 5 months ago (2015-07-06 20:10:55 UTC) #5
vmpstr
lgtm
5 years, 5 months ago (2015-07-06 20:12:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222243005/20001
5 years, 5 months ago (2015-07-06 20:21:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 21:36:52 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 21:39:04 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0aa02af8e3030bfb52c6c905d53f18643df2c68c
Cr-Commit-Position: refs/heads/master@{#337484}

Powered by Google App Engine
This is Rietveld 408576698