Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1221333008: Fix unused private field errors in components/nacl/. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@media_private_fields
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused private field errors in components/nacl/. This is fixing the build errors on Linux when building 'nacl' with DISALLOW_COPY_AND_ASSIGN using "=delete". BUG=447445 Committed: https://crrev.com/c5317ced56f1c86bd3c669ef1ab77eca649d2761 Cr-Commit-Position: refs/heads/master@{#337508}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M components/nacl/loader/nacl_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_main_platform_delegate.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M components/nacl/loader/nacl_main_platform_delegate_linux.cc View 1 1 chunk +2 lines, -9 lines 0 comments Download
M components/nacl/loader/nacl_main_platform_delegate_mac.mm View 1 1 chunk +2 lines, -9 lines 0 comments Download
M components/nacl/loader/nacl_main_platform_delegate_win.cc View 1 2 1 chunk +4 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-06 19:07:12 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/1221333008/diff/1/components/nacl/loader/nacl_main_platform_delegate.h File components/nacl/loader/nacl_main_platform_delegate.h (right): https://codereview.chromium.org/1221333008/diff/1/components/nacl/loader/nacl_main_platform_delegate.h#newcode18 components/nacl/loader/nacl_main_platform_delegate.h:18: void EnableSandbox(); I wonder if it's cleaner to just ...
5 years, 5 months ago (2015-07-06 19:31:31 UTC) #3
mlamouri (slow - plz ping)
PTAL. https://codereview.chromium.org/1221333008/diff/1/components/nacl/loader/nacl_main_platform_delegate.h File components/nacl/loader/nacl_main_platform_delegate.h (right): https://codereview.chromium.org/1221333008/diff/1/components/nacl/loader/nacl_main_platform_delegate.h#newcode18 components/nacl/loader/nacl_main_platform_delegate.h:18: void EnableSandbox(); On 2015/07/06 at 19:31:31, jvoung wrote: ...
5 years, 5 months ago (2015-07-06 20:21:23 UTC) #4
jvoung (off chromium)
LGTM thank you!
5 years, 5 months ago (2015-07-06 20:54:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221333008/20001
5 years, 5 months ago (2015-07-06 21:00:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/55963) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 5 months ago (2015-07-06 21:45:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221333008/40001
5 years, 5 months ago (2015-07-06 21:50:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-06 22:57:10 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 22:58:14 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5317ced56f1c86bd3c669ef1ab77eca649d2761
Cr-Commit-Position: refs/heads/master@{#337508}

Powered by Google App Engine
This is Rietveld 408576698