PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

content/common/navigation_params.h

Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 86e5e06917fd0946b456f2b467a3790cfe58c223..d1c330748e3fe146c0d209255d33316b680fae3a 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -22,6 +22,12 @@ class RefCountedMemory;
 
 namespace content {
 
+// This is not used outside of the PlzNavigate project.

[carlosk, 2015/07/03 15:39:03]

nit: This is generally indicated by having:
// PlzNavigate
As the first line of your method's comment documentation (see Navigator.h for
instance).

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Done.

+// Helper function to determine if the navigation request to |url| should be

[clamy, 2015/07/03 15:02:23]

nit: s/navigation request/navigation
nit: s/should be sent/should make a request

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Done.

+// sent to the network stack. It will not be sent for data URLs or JavaScript
+// URLs, cases where no network request needs to be made.
+bool ShouldMakeNetworkRequestForURL(const GURL& url);

[nasko, 2015/07/06 11:06:16]

When this method is used on the renderer side, it isn't really deciding whether
to send a network request or not. It is deciding whether to even make the
request to the browser process.

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Keeping the same name, per our offline chat. I clarified the comments.

+
 // The following structures hold parameters used during a navigation. In
 // particular they are used by FrameMsg_Navigate, FrameMsg_CommitNavigation and
 // FrameHostMsg_BeginNavigation.