PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/time/time.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace base {
 class RefCountedMemory;
 }
 
 namespace content {
 
+// This is not used outside of the PlzNavigate project.

[carlosk, 2015/07/03 15:39:03]

nit: This is generally indicated by having:
// PlzNavigate
As the first line of your method's comment documentation (see Navigator.h for
instance).

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Done.

+// Helper function to determine if the navigation request to |url| should be

[clamy, 2015/07/03 15:02:23]

nit: s/navigation request/navigation
nit: s/should be sent/should make a request

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Done.

+// sent to the network stack. It will not be sent for data URLs or JavaScript
+// URLs, cases where no network request needs to be made.
+bool ShouldMakeNetworkRequestForURL(const GURL& url);

[nasko, 2015/07/06 11:06:16]

When this method is used on the renderer side, it isn't really deciding whether
to send a network request or not. It is deciding whether to even make the
request to the browser process.

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Keeping the same name, per our offline chat. I clarified the comments.

+
 // The following structures hold parameters used during a navigation. In
 // particular they are used by FrameMsg_Navigate, FrameMsg_CommitNavigation and
 // FrameHostMsg_BeginNavigation.
 
 // Provided by the browser or the renderer -------------------------------------
 
 // Used by all navigation IPCs.
 struct CONTENT_EXPORT CommonNavigationParams {
   CommonNavigationParams();
   CommonNavigationParams(const GURL& url,
@@ skipping 218 matching lines @@
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_