Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: content/common/navigation_params.cc

Issue 1222203004: PlzNavigate: Do not send synchronous navigations from the renderer to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index 8b70c8ffb9718acfc22352f71d3643591cad57c7..d57b036fb29325ba6e9c9e76897d4040ad67aac6 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -8,6 +8,14 @@
namespace content {
+// static
+bool CommonNavigationParams::ShouldMakeNetworkRequest(const GURL& url) {
+ // Data and Javascript urls should not make network requests.
+ // TODO(clamy): same document navigations should not make network requests.
clamy 2015/07/03 11:41:44 Please add a DCHECK that browser-side navigation i
Fabrice (no longer in Chrome) 2015/07/03 14:55:35 Similar checks in the code are CHECKS and not DCHE
+ return !url.SchemeIs(url::kDataScheme) && url != GURL(url::kAboutBlankURL) &&
+ !url.SchemeIs(url::kJavaScriptScheme);
+}
+
CommonNavigationParams::CommonNavigationParams()
: transition(ui::PAGE_TRANSITION_LINK),
navigation_type(FrameMsg_Navigate_Type::NORMAL),

Powered by Google App Engine
This is Rietveld 408576698