PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "base/memory/ref_counted_memory.h"
 
 namespace content {
 
+// static
+bool CommonNavigationParams::ShouldMakeNetworkRequest(const GURL& url) {
+  // Data and Javascript urls should not make network requests.
+  // TODO(clamy): same document navigations should not make network requests.

[clamy, 2015/07/03 11:41:44]

Please add a DCHECK that browser-side navigation is enabled. We don't want other
people to use it right now.

[Fabrice (no longer in Chrome), 2015/07/03 14:55:35]

Similar checks in the code are CHECKS and not DCHECKS so I used that instead.
Done.

+  return !url.SchemeIs(url::kDataScheme) && url != GURL(url::kAboutBlankURL) &&
+         !url.SchemeIs(url::kJavaScriptScheme);
+}
+
 CommonNavigationParams::CommonNavigationParams()
     : transition(ui::PAGE_TRANSITION_LINK),
       navigation_type(FrameMsg_Navigate_Type::NORMAL),
       allow_download(true),
       report_type(FrameMsg_UILoadMetricsReportType::NO_REPORT) {
 }
 
 CommonNavigationParams::CommonNavigationParams(
     const GURL& url,
     const Referrer& referrer,
@@ skipping 115 matching lines @@
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content