base/logging.h - Issue 12221152: Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 12221152: Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 5db73b3adb7045a92b83a20cbf4d0dd957f97ba2..885235439b292408d5bd0b316018863c1390853f 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -982,7 +982,8 @@ inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) {

#define NOTIMPLEMENTED() do {\

static int count = 0;\

jar (doing other things) 2013/02/13 01:49:40 nit: how about changing this to: static bool ran_

LOG_IF(ERROR, 0 == count++) << NOTIMPLEMENTED_MSG;\

-} while(0)

+} while(0);\

+EAT_STREAM_PARAMETERS

#endif

#endif // BASE_LOGGING_H_

« no previous file with comments | « no previous file | no next file » | no next file with comments »