base/logging.h - Issue 12221152: Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/logging.h

Issue 12221152: Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_LOGGING_H_	5 #ifndef BASE_LOGGING_H_

6 #define BASE_LOGGING_H_	6 #define BASE_LOGGING_H_

7	7

8 #include <cassert>	8 #include <cassert>

9 #include <string>	9 #include <string>

10 #include <cstring>	10 #include <cstring>

(...skipping 962 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
973 // TODO, figure out how to generate a warning	973 // TODO, figure out how to generate a warning

974 #define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)	974 #define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)

975 #elif NOTIMPLEMENTED_POLICY == 2	975 #elif NOTIMPLEMENTED_POLICY == 2

976 #define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)	976 #define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED)

977 #elif NOTIMPLEMENTED_POLICY == 3	977 #elif NOTIMPLEMENTED_POLICY == 3

978 #define NOTIMPLEMENTED() NOTREACHED()	978 #define NOTIMPLEMENTED() NOTREACHED()

979 #elif NOTIMPLEMENTED_POLICY == 4	979 #elif NOTIMPLEMENTED_POLICY == 4

980 #define NOTIMPLEMENTED() LOG(ERROR) << NOTIMPLEMENTED_MSG	980 #define NOTIMPLEMENTED() LOG(ERROR) << NOTIMPLEMENTED_MSG

981 #elif NOTIMPLEMENTED_POLICY == 5	981 #elif NOTIMPLEMENTED_POLICY == 5

982 #define NOTIMPLEMENTED() do {\	982 #define NOTIMPLEMENTED() do {\

983 static int count = 0;\	983 static int count = 0;\
	jar (doing other things) 2013/02/13 01:49:40 nit: how about changing this to: static bool ran_ nit: how about changing this to: static bool ran_once = false;
984 LOG_IF(ERROR, 0 == count++) << NOTIMPLEMENTED_MSG;\	984 LOG_IF(ERROR, 0 == count++) << NOTIMPLEMENTED_MSG;\

985 } while(0)	985 } while(0);\

	986 EAT_STREAM_PARAMETERS

986 #endif	987 #endif

987	988

988 #endif // BASE_LOGGING_H_	989 #endif // BASE_LOGGING_H_

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »