Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 12221130: Revert 181798 for excessive leaks. (Closed)

Created:
7 years, 10 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, markusheintz_
Visibility:
Public.

Description

Revert 181798 for excessive leaks: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heapcheck/builds/14990 http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339 > Remove NativeTabbedPane[Win|Wrapper]; promote Views impl. > > Remove NativeTabbedPaneWin and NativeTabbedPaneWrapper. > ( its last use was eliminated in http://crrev.com/180924 ) > Write a TabbedPane based on NativeTabbedPaneViews. > Update unit tests; cleanup; etc. > > BUG=138059 > TEST=No observable tabbed pane appearance/behavior changes (see the WebsiteSettingsPopupView and CollectedCookiesView); unit tests. > R=markusheintz@chromium.org,sky@chromium.org,ben@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12225042 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -353 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A + ui/views/controls/tabbed_pane/native_tabbed_pane_views.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/controls/tabbed_pane/native_tabbed_pane_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/controls/tabbed_pane/native_tabbed_pane_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.h View 3 chunks +45 lines, -21 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 2 chunks +86 lines, -289 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc View 4 chunks +119 lines, -29 lines 0 comments Download
M ui/views/examples/tabbed_pane_example.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/examples/tabbed_pane_example.cc View 5 chunks +8 lines, -3 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 3 chunks +59 lines, -3 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 12 chunks +35 lines, -8 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
7 years, 10 months ago (2013-02-12 02:44:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698