Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: ui/views/controls/tabbed_pane/tabbed_pane.h

Issue 12221130: Revert 181798 for excessive leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/tabbed_pane/tabbed_pane.h
===================================================================
--- ui/views/controls/tabbed_pane/tabbed_pane.h (revision 181830)
+++ ui/views/controls/tabbed_pane/tabbed_pane.h (working copy)
@@ -12,9 +12,8 @@
namespace views {
-class Tab;
+class NativeTabbedPaneWrapper;
class TabbedPaneListener;
-class TabStrip;
// TabbedPane is a view that shows tabs. When the user clicks on a tab, the
// associated view is displayed.
@@ -25,13 +24,20 @@
TabbedPaneListener* listener() const { return listener_; }
void set_listener(TabbedPaneListener* listener) { listener_ = listener; }
+#if defined(OS_WIN) && !defined(USE_AURA)
+ bool use_native_win_control() { return use_native_win_control_; }
+ void set_use_native_win_control(bool use_native_win_control) {
+ use_native_win_control_ = use_native_win_control;
+ }
+#endif
- int selected_tab_index() const { return selected_tab_index_; }
-
// Returns the number of tabs.
int GetTabCount();
- // Returns the contents of the selected tab or NULL if there is none.
+ // Returns the index of the selected tab.
+ int GetSelectedTabIndex();
+
+ // Returns the contents of the selected tab.
View* GetSelectedTab();
// Adds a new tab at the end of this TabbedPane with the specified |title|.
@@ -39,45 +45,63 @@
// the TabbedPane.
void AddTab(const string16& title, View* contents);
- // Adds a new tab at |index| with |title|. |contents| is the view displayed
- // when the tab is selected and is owned by the TabbedPane. If the tabbed pane
- // is currently empty, the new tab is selected.
- void AddTabAtIndex(int index, const string16& title, View* contents);
+ // Adds a new tab at |index| with |title|.
+ // |contents| is the view displayed when the tab is selected and is owned by
+ // the TabbedPane. If |select_if_first_tab| is true and the tabbed pane is
+ // currently empty, the new tab is selected. If you pass in false for
+ // |select_if_first_tab| you need to explicitly invoke SelectTabAt, otherwise
+ // the tabbed pane will not have a valid selection.
+ void AddTabAtIndex(int index,
+ const string16& title,
+ View* contents,
+ bool select_if_first_tab);
+ // Removes the tab at |index| and returns the associated content view.
+ // The caller becomes the owner of the returned view.
+ View* RemoveTabAtIndex(int index);
+
// Selects the tab at |index|, which must be valid.
void SelectTabAt(int index);
- // Selects |tab| (the tabstrip view, not its content) if it is valid.
- void SelectTab(Tab* tab);
+ void SetAccessibleName(const string16& name);
// Overridden from View:
virtual gfx::Size GetPreferredSize() OVERRIDE;
+ protected:
+ // The object that actually implements the tabbed-pane.
+ // Protected for tests access.
+ NativeTabbedPaneWrapper* native_tabbed_pane_;
+
private:
- // Get the Tab (the tabstrip view, not its content) at the valid |index|.
- Tab* GetTabAt(int index);
+ // The tabbed-pane's class name.
+ static const char kViewClassName[];
+ // We support Ctrl+Tab and Ctrl+Shift+Tab to navigate tabbed option pages.
+ void LoadAccelerators();
+
// Overridden from View:
virtual void Layout() OVERRIDE;
virtual void ViewHierarchyChanged(bool is_add,
View* parent,
View* child) OVERRIDE;
+ // Handles Ctrl+Tab and Ctrl+Shift+Tab navigation of pages.
virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
virtual std::string GetClassName() const OVERRIDE;
virtual void OnFocus() OVERRIDE;
+ virtual void OnPaintFocusBorder(gfx::Canvas* canvas) OVERRIDE;
virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- // A listener notified when tab selection changes. Weak, not owned.
+#if defined(OS_WIN) && !defined(USE_AURA)
+ bool use_native_win_control_;
+#endif
+
+ // Our listener. Not owned. Notified when tab selection changes.
TabbedPaneListener* listener_;
- // The tab strip and contents container. The child indices of these members
- // correspond to match each Tab with its respective content View.
- TabStrip* tab_strip_;
- View* contents_;
+ // The accessible name of this tabbed pane.
+ string16 accessible_name_;
- // The selected tab index or -1 if invalid.
- int selected_tab_index_;
-
DISALLOW_COPY_AND_ASSIGN(TabbedPane);
};
« no previous file with comments | « ui/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h ('k') | ui/views/controls/tabbed_pane/tabbed_pane.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698