Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5803)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm

Issue 12221124: Omnibox Mac: Always allow up and down arrow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
index 38c45afeccd745b0899c3b97a9c2ee88dedc0e88..f42ec2656c3654d08345c781ae42295cdb44847f 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
@@ -30,6 +30,10 @@ class MockOmniboxEditModel : public OmniboxEditModel {
int up_or_down_count() const { return up_or_down_count_; }
+ void set_up_or_down_count(int count) {
+ up_or_down_count_ = count;
+ }
+
private:
int up_or_down_count_;
@@ -167,3 +171,33 @@ TEST_F(OmniboxViewMacTest, SetInstantSuggestion) {
EXPECT_EQ(string16(), view.GetText());
EXPECT_EQ(string16(), view.GetInstantSuggestion());
}
+
+TEST_F(OmniboxViewMacTest, UpDownArrow) {
+ OmniboxViewMac view(NULL, NULL, profile(), NULL, NULL);
+
+ // This is deleted by the omnibox view.
+ MockOmniboxEditModel* model =
+ new MockOmniboxEditModel(&view, NULL, profile());
+ SetModel(&view, model);
+
+ MockOmniboxPopupView popup_view;
+ OmniboxPopupModel popup_model(&popup_view, model);
+
+ // With popup closed verify that pressing up and down arrow works.
+ popup_view.set_is_open(false);
+ model->set_up_or_down_count(0);
+ view.OnDoCommandBySelector(@selector(moveDown:));
+ EXPECT_EQ(1, model->up_or_down_count());
+ model->set_up_or_down_count(0);
+ view.OnDoCommandBySelector(@selector(moveUp:));
+ EXPECT_EQ(-1, model->up_or_down_count());
+
+ // With popup open verify that pressing up and down arrow works.
+ popup_view.set_is_open(true);
+ model->set_up_or_down_count(0);
+ view.OnDoCommandBySelector(@selector(moveDown:));
+ EXPECT_EQ(1, model->up_or_down_count());
+ model->set_up_or_down_count(0);
+ view.OnDoCommandBySelector(@selector(moveUp:));
+ EXPECT_EQ(-1, model->up_or_down_count());
+}
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698