Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: public/platform/WebCallbacks.h

Issue 1222103006: (WONT COMMIT) Make CallbackPromiseAdapter accept a bool object passed by value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebCallbacks.h
diff --git a/public/platform/WebCallbacks.h b/public/platform/WebCallbacks.h
index 69f4b7ff9e6c376a259dd55839ff2d893c4a67b9..0163ff26e2cf778bbd888bc1810fe1ce337e9750 100644
--- a/public/platform/WebCallbacks.h
+++ b/public/platform/WebCallbacks.h
@@ -37,6 +37,7 @@ template<typename S, typename T>
class WebCallbacks {
public:
virtual ~WebCallbacks() { }
+ virtual void onSuccess(S) { }
yhirano 2015/07/08 11:18:43 I don't like having two onSuccess functions in one
yhirano 2015/07/08 11:36:19 No, I was confused. I wanted to say moving existi
virtual void onSuccess(S*) { }
virtual void onError(T*) { }
};
@@ -53,6 +54,7 @@ template<typename S>
class WebCallbacks<S, void> {
public:
virtual ~WebCallbacks() { }
+ virtual void onSuccess(S) { }
virtual void onSuccess(S*) { }
virtual void onError() { }
};
« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698