Source/modules/push_messaging/PushSubscriptionCallbacks.h - Issue 1222103006: (WONT COMMIT) Make CallbackPromiseAdapter accept a bool object passed by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushSubscriptionCallbacks.h

Issue 1222103006: (WONT COMMIT) Make CallbackPromiseAdapter accept a bool object passed by value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/push_messaging/PushSubscriptionCallbacks.h

diff --git a/Source/modules/push_messaging/PushSubscriptionCallbacks.h b/Source/modules/push_messaging/PushSubscriptionCallbacks.h

index 75cd6d3ddf727f9ddefb006b9e6f5c5646130daf..173bffaa7931a8f4da6921fa35d8929f77a0fdb1 100644

--- a/Source/modules/push_messaging/PushSubscriptionCallbacks.h

+++ b/Source/modules/push_messaging/PushSubscriptionCallbacks.h

@@ -7,6 +7,7 @@

#include "platform/heap/Handle.h"

#include "public/platform/WebCallbacks.h"

+#include "public/platform/modules/push_messaging/WebPushSubscription.h"

#include "wtf/Noncopyable.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

@@ -16,7 +17,6 @@ namespace blink {

class ServiceWorkerRegistration;

class ScriptPromiseResolver;

struct WebPushError;

-struct WebPushSubscription;

// PushSubscriptionCallbacks is an implementation of WebPushSubscriptionCallbacks

// that will resolve the underlying promise depending on the result passed to

« no previous file with comments | « Source/bindings/core/v8/CallbackPromiseAdapter.h ('k') | public/platform/WebCallbacks.h » ('j') | public/platform/WebCallbacks.h » ('J')