Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1222103006: (WONT COMMIT) Make CallbackPromiseAdapter accept a bool object passed by value (Closed)

Created:
5 years, 5 months ago by nhiroki
Modified:
5 years, 5 months ago
Reviewers:
yhirano
CC:
blink-reviews, arv+blink, vivekg_samsung, johnme+watch_chromium.org, vivekg, mvanouwerkerk+watch_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make CallbackPromiseAdapter accept a bool object passed by value Depends on https://codereview.chromium.org/1218073019 BUG=493531

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -35 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 5 chunks +21 lines, -34 lines 0 comments Download
M Source/modules/push_messaging/PushSubscriptionCallbacks.h View 2 chunks +1 line, -1 line 0 comments Download
M public/platform/WebCallbacks.h View 2 chunks +2 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
yhirano
https://codereview.chromium.org/1222103006/diff/1/public/platform/WebCallbacks.h File public/platform/WebCallbacks.h (right): https://codereview.chromium.org/1222103006/diff/1/public/platform/WebCallbacks.h#newcode40 public/platform/WebCallbacks.h:40: virtual void onSuccess(S) { } I don't like having ...
5 years, 5 months ago (2015-07-08 11:18:43 UTC) #2
yhirano
https://codereview.chromium.org/1222103006/diff/1/public/platform/WebCallbacks.h File public/platform/WebCallbacks.h (right): https://codereview.chromium.org/1222103006/diff/1/public/platform/WebCallbacks.h#newcode40 public/platform/WebCallbacks.h:40: virtual void onSuccess(S) { } On 2015/07/08 11:18:43, yhirano ...
5 years, 5 months ago (2015-07-08 11:36:19 UTC) #3
nhiroki
5 years, 5 months ago (2015-07-10 04:29:01 UTC) #4 
As discussed offline w/ yhirano@, I'll close this (see
https://codereview.chromium.org/1211353004/#msg14 and subsequent comments for
details)

Powered by Google App Engine
This is Rietveld 408576698