Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 12220089: Roll Clang r170392:r174491. (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, dmikurube+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org, inferno
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase, and target r174491 instead #

Total comments: 1

Patch Set 3 : Rebase for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/common.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
hans
Uploaded new patch. This targets r174491 which is basically the same, but those binaries got ...
7 years, 10 months ago (2013-02-12 13:16:39 UTC) #1
Alexander Potapenko
https://chromiumcodereview.appspot.com/12220089/diff/2002/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://chromiumcodereview.appspot.com/12220089/diff/2002/tools/clang/scripts/update.sh#newcode11 tools/clang/scripts/update.sh:11: CLANG_REVISION=174491 Please upload a new diff.
7 years, 10 months ago (2013-02-12 13:24:45 UTC) #2
hans
On 2013/02/12 13:24:45, Alexander Potapenko wrote: > https://chromiumcodereview.appspot.com/12220089/diff/2002/tools/clang/scripts/update.sh#newcode11 > tools/clang/scripts/update.sh:11: CLANG_REVISION=174491 > Please upload a ...
7 years, 10 months ago (2013-02-12 13:25:44 UTC) #3
Alexander Potapenko
Abhishek, FYI this roll may break your CF builders. Until I'm done making the new ...
7 years, 10 months ago (2013-02-12 13:26:02 UTC) #4
Alexander Potapenko
On 2013/02/12 13:26:02, Alexander Potapenko wrote: > Abhishek, FYI this roll may break your CF ...
7 years, 10 months ago (2013-02-12 13:29:06 UTC) #5
Alexander Potapenko
updated update.sh
7 years, 10 months ago (2013-02-12 14:32:36 UTC) #6
aarya
On 2013/02/12 14:32:36, Alexander Potapenko wrote: > updated update.sh i am not using the mac ...
7 years, 10 months ago (2013-02-12 16:38:32 UTC) #7
Nico
Should the asan bug be on the bug line too? Anyways, lgtm.
7 years, 10 months ago (2013-02-12 16:44:10 UTC) #8
hans
On 2013/02/12 16:44:10, Nico wrote: > Should the asan bug be on the bug line ...
7 years, 10 months ago (2013-02-12 16:50:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/12220089/8002
7 years, 10 months ago (2013-02-12 16:50:29 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110822
7 years, 10 months ago (2013-02-12 19:17:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/12220089/8002
7 years, 10 months ago (2013-02-12 19:22:26 UTC) #12
commit-bot: I haz the power
Change committed as 182023
7 years, 10 months ago (2013-02-12 21:40:16 UTC) #13
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 14:19:04 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698