When building Clang for Mac, make LC_ID_DYLIB of the ASan dynamic runtime to be relative to @execut…

When building Clang for Mac, make LC_ID_DYLIB of the ASan dynamic runtime to be relative to @executable_path.

BUG=170629
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181724

[Alexander Potapenko, 2013-01-17 12:49:16]

PTAL

[Alexander Potapenko, 2013-01-20 13:37:59]

On 2013/01/17 12:49:16, Alexander Potapenko wrote:
> PTAL

Nico, what do you think about this?
Were my arguments in crbug.com/170629 convincing enough, or do you still lean
towards having this done in Clang?

[Nico, 2013-01-22 16:13:21]

Please leave in a comment mentioning that this might be transitional.

Long-term, this is fairly certainly the wrong place to put this. It needs to be
done either in clang's build system, in clang's driver at build time, or in the
build system. I suppose we'll wait and see how Xcode's going to handle it.

https://codereview.chromium.org/11946043/diff/1/tools/clang/scripts/package.sh
File tools/clang/scripts/package.sh (right):

https://codereview.chromium.org/11946043/diff/1/tools/clang/scripts/package.s...
tools/clang/scripts/package.sh:70: ASAN_DYLIB=`find "${LLVM_LIB_DIR}/clang"
-type f -path *"${ASAN_DYLIB_NAME}"`
Use $() instead of ``. Doesn't the '*' have to be quoted? Else it's expanded by
the shell and doesn't make it to find, right?

https://codereview.chromium.org/11946043/diff/1/tools/clang/scripts/package.s...
tools/clang/scripts/package.sh:71: install_name_tool -id
@executable_path/${ASAN_DYLIB} "${ASAN_DYLIB}"
quotes for the first ${ASAN_DYLIB} too

[Nico, 2013-01-22 16:13:37]

…forgot to say: Until then, with the changes mentioned above, this lgtm.

[Alexander Potapenko, 2013-02-11 18:35:01]

On 2013/01/22 16:13:37, Nico wrote:
> …forgot to say: Until then, with the changes mentioned above, this lgtm.

Fixed the comments.
I wasn't sure about this patch for some amount of time, but looks like I'll have
to land it in order to have working runtime.