Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221833002: Remove the Images category from Site Settings. (Closed)

Created:
5 years, 5 months ago by Finnur
Modified:
5 years, 5 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Images category from Site Settings. It overlaps with the Data Saver feature and should not have been added on mobile. BUG=505844 Committed: https://crrev.com/ff717a9063ca1acb955fef71b9366c9b9fe00e9c Cr-Commit-Position: refs/heads/master@{#336870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -195 lines) Patch
M chrome/android/java/res/xml/content_preferences.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/res/xml/single_website_preferences.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentPreferences.java View 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java View 6 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 7 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 3 chunks +0 lines, -27 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java View 7 chunks +2 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java View 2 chunks +0 lines, -47 lines 0 comments Download
D chrome/test/data/android/images.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/android/img.png View Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
Finnur
5 years, 5 months ago (2015-06-30 16:14:33 UTC) #2
newt (away)
lgtm
5 years, 5 months ago (2015-06-30 18:10:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221833002/1
5 years, 5 months ago (2015-06-30 20:37:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 20:45:25 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 20:46:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ff717a9063ca1acb955fef71b9366c9b9fe00e9c
Cr-Commit-Position: refs/heads/master@{#336870}

Powered by Google App Engine
This is Rietveld 408576698