chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java - Issue 1221833002: Remove the Images category from Site Settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

Issue 1221833002: Remove the Images category from Site Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

index 8c7ffc97ed6d95241bde9d199756a51836011f41..5a50e5dd38090fa3207574a249d8659eb892d6f2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

@@ -14,7 +14,6 @@ public class WebsiteSettingsCategoryFilter {

private static final String FILTER_ALL_SITES = "all_sites";

private static final String FILTER_CAMERA = "camera";

private static final String FILTER_COOKIES = "cookies";

- private static final String FILTER_IMAGES = "images";

private static final String FILTER_JAVASCRIPT = "javascript";

private static final String FILTER_DEVICE_LOCATION = "device_location";

private static final String FILTER_FULLSCREEN = "fullscreen";

@@ -39,8 +38,6 @@ public class WebsiteSettingsCategoryFilter {

return ContentSettingsType.CONTENT_SETTINGS_TYPE_FULLSCREEN;

} else if (showGeolocationSites(key)) {

return ContentSettingsType.CONTENT_SETTINGS_TYPE_GEOLOCATION;

- } else if (showImagesSites(key)) {

- return ContentSettingsType.CONTENT_SETTINGS_TYPE_IMAGES;

} else if (showJavaScriptSites(key)) {

return ContentSettingsType.CONTENT_SETTINGS_TYPE_JAVASCRIPT;

} else if (showMicrophoneSites(key)) {

@@ -97,14 +94,6 @@ public class WebsiteSettingsCategoryFilter {

/**

* @param filterValue A category value.

- * @return Whether the category passed is the images category.

- */

- public boolean showImagesSites(String filterValue) {

- return filterValue.equals(FILTER_IMAGES);

- }

- /**

- * @param filterValue A category value.

* @return Whether the category passed is the javascript category.

public boolean showJavaScriptSites(String filterValue) {