samples/swarm/swarm_ui_lib/view/view.dart - Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/swarm_ui_lib/view/view.dart

Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/swarm/swarm_ui_lib/view/ConveyorView.dart ('K') | « samples/swarm/swarm_ui_lib/view/SliderMenu.dart ('k') | samples/swipe/web/swipe.dart » ('j') | samples/tests/samples/dartcombat/dartcombat_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samples/swarm/swarm_ui_lib/view/view.dart

diff --git a/samples/swarm/swarm_ui_lib/view/view.dart b/samples/swarm/swarm_ui_lib/view/view.dart

index 32dba6d4b1488b2ce3845eb98e415ac21c5ba62c..5f372783a38d1c9bee343275949d9d3575e04935 100644

--- a/samples/swarm/swarm_ui_lib/view/view.dart

+++ b/samples/swarm/swarm_ui_lib/view/view.dart

@@ -337,7 +337,7 @@ class View implements Positionable {

changedComplete = true;

});

- window.setImmediate(() {

+ window.immediate.then((_) {

if (!changedComplete) {

changed.complete(false);

}

@@ -353,7 +353,7 @@ class View implements Positionable {

// a good tradeoff?

if (ViewLayout.hasCustomLayout(this)) {

Completer sizeCompleter = new Completer<Size>();

- window.setImmediate(() {

+ window.immediate.then((_) {

sizeCompleter.complete(

new Size(_node.clientWidth, _node.clientHeight));

});