samples/tests/samples/dartcombat/dartcombat_test.dart - Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/tests/samples/dartcombat/dartcombat_test.dart

Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/swarm/swarm_ui_lib/view/ConveyorView.dart ('K') | « samples/swipe/web/swipe.dart ('k') | samples/tests/samples/lib/layout/grid_layout_demo.dart » ('j') | samples/tests/samples/lib/layout/layout_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samples/tests/samples/dartcombat/dartcombat_test.dart

diff --git a/samples/tests/samples/dartcombat/dartcombat_test.dart b/samples/tests/samples/dartcombat/dartcombat_test.dart

index 1b91aeaf3d5a8a047e040accc9c3a304650a9cc3..259cfd9748eea23fceb985f6a8c189ebfbdabd77 100644

--- a/samples/tests/samples/dartcombat/dartcombat_test.dart

+++ b/samples/tests/samples/dartcombat/dartcombat_test.dart

@@ -171,9 +171,9 @@ void _serialInvokeAsync(List closures) {

closures[i]();

i++;

if (i < length) {

- window.setTimeout(expectAsync0(invokeNext), 0);

+ new Timer(const Duration(milliseconds: 0), expectAsync0(invokeNext));

floitsch 2013/02/13 10:03:07 Timer.run

Emily Fortuna 2013/02/13 20:19:44 Done.

}

- window.setTimeout(expectAsync0(invokeNext), 0);

+ new Timer(const Duration(milliseconds: 0), expectAsync0(invokeNext));

floitsch 2013/02/13 10:03:07 Timer.run

Emily Fortuna 2013/02/13 20:19:44 Done.

}