Distinguish slow from fast sloppy arguments

src/elements.h

Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index b98e84ecea38ef1511ccd70896339b9c34221557..815a9327caa21de22a83f19734e42304c0e562d9 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -13,6 +13,16 @@
 namespace v8 {
 namespace internal {
 
+class FastHoleyObjectElementsAccessor;
+class DictionaryElementsAccessor;
+class FastSloppyArgumentsElementsAccessor;
+class SlowSloppyArgumentsElementsAccessor;
+template <ElementsKind Kind>
+class ElementsKindTraits;
+template <typename SloppyArgumentsElementsAccessorSubclass,
+          typename ArgumentsAccessor, typename KindTraits>
+class SloppyArgumentsElementsAccessor;

[Igor Sheludko, 2015/07/02 13:28:42]

These declarations should not be here.

[Toon Verwaest, 2015/07/02 13:49:02]

Done.

+
 // Abstract base class for handles that can operate on objects with differing
 // ElementsKinds.
 class ElementsAccessor {
@@ -149,8 +159,13 @@ class ElementsAccessor {
                    uint32_t new_capacity) = 0;
 
  protected:
-  friend class SloppyArgumentsElementsAccessor;
   friend class LookupIterator;
+  friend class SloppyArgumentsElementsAccessor<
+      FastSloppyArgumentsElementsAccessor, FastHoleyObjectElementsAccessor,
+      ElementsKindTraits<FAST_SLOPPY_ARGUMENTS_ELEMENTS> >;
+  friend class SloppyArgumentsElementsAccessor<
+      SlowSloppyArgumentsElementsAccessor, DictionaryElementsAccessor,
+      ElementsKindTraits<SLOW_SLOPPY_ARGUMENTS_ELEMENTS> >;

[Igor Sheludko, 2015/07/02 13:28:42]

These friend declarations should not be here. You can move them to
ElementsAccessorBase<>.

[Toon Verwaest, 2015/07/02 13:49:02]

Done.

 
   static ElementsAccessor* ForArray(FixedArrayBase* array);