Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12217101: Replace FilePath with base::FilePath in some more top level directories. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, stevenjb+watch_chromium.org, frankf+watch_chromium.org, ben+watch_chromium.org, ilevy+watch_chromium.org, yfriedman+watch_chromium.org, tim (not reviewing), jonathan.backer, Raghu Simha, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, haitaol1, klundberg+watch_chromium.org, akalin, Ian Vollick, tfarina, sail+watch_chromium.org, jln+watch_chromium.org, cc-bugs_chromium.org, James Su, agl, jshin+watch_chromium.org
Visibility:
Public.

Description

Replace FilePath with base::FilePath in some more top level directories. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -556 lines) Patch
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/mac/audio_device_listener_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_unified_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_posix.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/base/media_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/test_data_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/test/ffmpeg_tests/ffmpeg_tests.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/tools/demuxer_bench/demuxer_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/media_bench/media_bench.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/seek_tester/seek_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/screen/screen_capturer_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/capture/screen/screen_capturer_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/webm/chromeos/webm_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/emf_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/image.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M rlz/lib/recursive_cross_process_lock_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/test/rlz_test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/broker_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_inheritance_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M skia/ext/image_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/internal_api/internal_components_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/internal_components_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/internal_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/test/test_internal_components_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/test/test_internal_components_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_backing_store_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M sync/test/local_sync_test_server.h View 1 chunk +4 lines, -3 lines 0 comments Download
M sync/test/local_sync_test_server.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M sync/tools/testserver/run_sync_testserver.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/android/device_stats_monitor/device_stats_monitor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/image_diff.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M tools/memory_watcher/memory_watcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M ui/aura/test/test_aura_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/download_file_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drag_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drag_utils.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data.h View 6 chunks +13 lines, -13 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_gtk.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_gtk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 10 chunks +14 lines, -13 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/data_pack.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 8 chunks +17 lines, -13 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 11 chunks +21 lines, -20 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ui_base_paths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M ui/gfx/color_profile_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gfx_paths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/icon_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util_unittest.cc View 8 chunks +13 lines, -9 lines 0 comments Download
M ui/gfx/video_decode_acceleration_support_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_implementation_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_implementation_mac.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl.h View 2 chunks +12 lines, -11 lines 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc View 14 chunks +28 lines, -27 lines 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl_kde.cc View 18 chunks +35 lines, -31 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 5 chunks +16 lines, -15 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 9 chunks +28 lines, -24 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 22 chunks +40 lines, -37 lines 0 comments Download
M ui/shell_dialogs/selected_file_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/shell_dialogs/selected_file_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/surface/accelerated_surface_transformer_win_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/surface/d3d9_utils_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/test/test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M win8/metro_driver/file_picker.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M win8/metro_driver/file_picker_ash.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M win8/metro_driver/secondary_tile.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/secondary_tile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/toast_notification_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/winrt_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=scherkus (since this includes media/)
7 years, 10 months ago (2013-02-10 05:15:01 UTC) #1
scherkus (not reviewing)
7 years, 10 months ago (2013-02-11 17:31:19 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698