Fix Y-flipped lighting in accelerated SVG reference filters in CSS. Since the compositor draws all…

Fix Y-flipped lighting in accelerated SVG reference filters in CSS.  Since the compositor draws all quads as origin-TopLeft, but Skia expects all render targets (and external textures) to be origin-BottomLeft, accelerated filters were being Y-flipped twice.  Since all of the CSS filters have symmetrical parameters, no-one noticed.  However, SVG filters (e.g., feSpecularLighting) have parameters which are not symmetrical in Y, so the lighting appeared upside-down.

Now that we have support in Skia for origin-TopLeft render targets, mark both the textures and render targets as origin-TopLeft, to reflect the compositor's convention.

BUG:  See webkit.org/b/104289


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181178

[Stephen White, 2013-02-06 19:43:35]

PTAL.

BTW, I tried to add these failures to webkit/tools/test_expectations.txt, but
that file seemed to have no effect.

[robertphillips, 2013-02-06 20:04:35]

LGTM

[jamesr, 2013-02-06 20:16:57]

lgtm

[danakj, 2013-02-06 20:20:48]

Wow, thanks for making the change so simple on the compositor site!

[danakj, 2013-02-06 20:20:53]

side*

[commit-bot: I haz the power, 2013-02-06 22:13:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/1

[commit-bot: I haz the power, 2013-02-06 22:13:50]

Failed to apply patch for cc/gl_renderer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/gl_renderer.cc
  Hunk #1 FAILED at 422.
  1 out of 2 hunks FAILED -- saving rejects to file cc/gl_renderer.cc.rej

Patch:       cc/gl_renderer.cc
Index: cc/gl_renderer.cc
diff --git a/cc/gl_renderer.cc b/cc/gl_renderer.cc
index
4c6cc417cd6c8949b061d45959478958801e3c63..58b6f46c154be653e431912f1055493c0a1975b0
100644
--- a/cc/gl_renderer.cc
+++ b/cc/gl_renderer.cc
@@ -422,6 +422,7 @@ static SkBitmap applyImageFilter(GLRenderer* renderer,
SkImageFilter* filter, Sc
     platformTextureDescription.fHeight = sourceTexture->size().height();
     platformTextureDescription.fConfig = kSkia8888_GrPixelConfig;
     platformTextureDescription.fTextureHandle = lock.textureId();
+    platformTextureDescription.fOrigin = kTopLeft_GrSurfaceOrigin;
     skia::RefPtr<GrTexture> texture =
skia::AdoptRef(grContext->createPlatformTexture(platformTextureDescription));
 
     // Place the platform texture inside an SkBitmap.
@@ -437,6 +438,7 @@ static SkBitmap applyImageFilter(GLRenderer* renderer,
SkImageFilter* filter, Sc
     desc.fWidth = source.width();
     desc.fHeight = source.height();
     desc.fConfig = kSkia8888_GrPixelConfig;
+    desc.fOrigin = kTopLeft_GrSurfaceOrigin;
     GrAutoScratchTexture scratchTexture(grContext, desc,
GrContext::kExact_ScratchTexMatch);
     skia::RefPtr<GrTexture> backingStore =
skia::AdoptRef(scratchTexture.detach());

[commit-bot: I haz the power, 2013-02-06 22:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/5

[commit-bot: I haz the power, 2013-02-07 02:40:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/5

[commit-bot: I haz the power, 2013-02-07 03:38:19]

Change committed as 181178