Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 12217047: Fix Y-flipped lighting in accelerated SVG reference filters in CSS. Since the compositor draws all… (Closed)

Created:
7 years, 7 months ago by Stephen White
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix Y-flipped lighting in accelerated SVG reference filters in CSS. Since the compositor draws all quads as origin-TopLeft, but Skia expects all render targets (and external textures) to be origin-BottomLeft, accelerated filters were being Y-flipped twice. Since all of the CSS filters have symmetrical parameters, no-one noticed. However, SVG filters (e.g., feSpecularLighting) have parameters which are not symmetrical in Y, so the lighting appeared upside-down. Now that we have support in Skia for origin-TopLeft render targets, mark both the textures and render targets as origin-TopLeft, to reflect the compositor's convention. BUG: See webkit.org/b/104289 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181178

Patch Set 1 #

Patch Set 2 : Updated to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cc/gl_renderer.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Stephen White
PTAL. BTW, I tried to add these failures to webkit/tools/test_expectations.txt, but that file seemed to ...
7 years, 7 months ago (2013-02-06 19:43:35 UTC) #1
robertphillips
LGTM
7 years, 7 months ago (2013-02-06 20:04:35 UTC) #2
jamesr
lgtm
7 years, 7 months ago (2013-02-06 20:16:57 UTC) #3
danakj
Wow, thanks for making the change so simple on the compositor site!
7 years, 7 months ago (2013-02-06 20:20:48 UTC) #4
danakj
side*
7 years, 7 months ago (2013-02-06 20:20:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/1
7 years, 7 months ago (2013-02-06 22:13:48 UTC) #6
commit-bot: I haz the power
Failed to apply patch for cc/gl_renderer.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-02-06 22:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/5
7 years, 7 months ago (2013-02-06 22:45:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/12217047/5
7 years, 7 months ago (2013-02-07 02:40:18 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-02-07 03:38:19 UTC) #10
Message was sent while issue was closed.
Change committed as 181178

Powered by Google App Engine
This is Rietveld 408576698