Issue 12217033: filemanager: Update the icons in the left nav.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12217033: filemanager: Update the icons in the left nav. (Closed)

Created:
7 years, 10 months ago by Haruki Sato

Modified:
7 years, 10 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

filemanager: Update the icons in the left nav. Update the existing icons and add Drive related icons. PNG files are crushed. gdrive.png is now drive.png. BUG=164504 TEST=Manually, open Files app and check the updated icons. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181196

Patch Set 1 #

Patch Set 2 : rename gdrive to drive. #

Patch Set 3 : jfyi, follow file namings. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-9 lines, --14 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/archive.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/device_hd.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/device_optical.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/device_sd.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/device_usb.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/downloads.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/2x/drive.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/2x/drive_offline.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/2x/drive_recent.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/2x/drive_shared.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/2x/folder.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/archive.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/device_hd.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/device_optical.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/device_sd.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/device_usb.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/downloads.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/images/files/volumes/drive.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/drive_offline.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/drive_recent.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/drive_shared.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/files/volumes/folder.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

Updated the left nav icons and some HTML structure. please check JS and CSS diffs. ...

7 years, 10 months ago (2013-02-06 08:58:53 UTC) #1

lgtm!

Expand Messages | Collapse Messages