Chromium Code Reviews
Help | Chromium Project | Sign in
(245)

Issue 12217033: filemanager: Update the icons in the left nav. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Haruki Sato
Modified:
1 year, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews_chromium.org, rginda+watch_chromium.org, arv
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

filemanager: Update the icons in the left nav.

Update the existing icons and add Drive related icons.
PNG files are crushed.
gdrive.png is now drive.png.


BUG=164504
TEST=Manually, open Files app and check the updated icons.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181196

Patch Set 1 #

Patch Set 2 : rename gdrive to drive. #

Patch Set 3 : jfyi, follow file namings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-9 lines, --14 lines) Lint Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 1 chunk +4 lines, -3 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/archive.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/device_hd.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/device_optical.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/device_sd.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/device_usb.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/downloads.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/2x/drive.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/2x/drive_offline.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/2x/drive_recent.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/2x/drive_shared.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/2x/folder.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/archive.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/device_hd.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/device_optical.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/device_sd.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/device_usb.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/downloads.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/images/files/volumes/drive.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/drive_offline.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/drive_recent.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/drive_shared.png View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/file_manager/images/files/volumes/folder.png View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 1 chunk +9 lines, -5 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Haruki Sato
Updated the left nav icons and some HTML structure. please check JS and CSS diffs. ...
1 year, 2 months ago #1
yoshiki
1 year, 2 months ago #2
lgtm!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6