chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1221693002: Fix accessibility issues in custom tab UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index 98a6c46a2abea2f831cd83833501918eb2a580fb..3d2e532c00feb366c154b9a80d2d73eafbe5781c 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -7,7 +7,8 @@

<org.chromium.chrome.browser.widget.TintedImageButton

android:id="@+id/close_button"

style="@style/ToolbarButton"

- android:layout_gravity="center_vertical" />

+ android:layout_gravity="center_vertical"

+ android:contentDescription="@string/close_tab" />

<ImageButton android:id="@+id/security_button"

style="@style/LocationBarButton"

android:layout_width="@dimen/location_bar_icon_width"

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | no next file with comments »