chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1221693002: Fix accessibility issues in custom tab UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar xmlns:android="http://sche mas.android.com/apk/res/android">	6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar xmlns:android="http://sche mas.android.com/apk/res/android">

7 <org.chromium.chrome.browser.widget.TintedImageButton	7 <org.chromium.chrome.browser.widget.TintedImageButton

8 android:id="@+id/close_button"	8 android:id="@+id/close_button"

9 style="@style/ToolbarButton"	9 style="@style/ToolbarButton"

10 android:layout_gravity="center_vertical" />	10 android:layout_gravity="center_vertical"

	11 android:contentDescription="@string/close_tab" />

11 <ImageButton android:id="@+id/security_button"	12 <ImageButton android:id="@+id/security_button"

12 style="@style/LocationBarButton"	13 style="@style/LocationBarButton"

13 android:layout_width="@dimen/location_bar_icon_width"	14 android:layout_width="@dimen/location_bar_icon_width"

14 android:layout_height="match_parent"	15 android:layout_height="match_parent"

15 android:layout_marginStart="48dp"	16 android:layout_marginStart="48dp"

16 android:scaleType="center"	17 android:scaleType="center"

17 android:layout_gravity="center_vertical"	18 android:layout_gravity="center_vertical"

18 android:alpha="0"	19 android:alpha="0"

19 android:visibility="gone"	20 android:visibility="gone"

20 android:contentDescription="@string/accessibility_toolbar_btn_site_info" />	21 android:contentDescription="@string/accessibility_toolbar_btn_site_info" />

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 android:contentDescription="@string/accessibility_toolbar_btn_menu"	71 android:contentDescription="@string/accessibility_toolbar_btn_menu"

71 android:background="@null" />	72 android:background="@null" />

72 <org.chromium.chrome.browser.widget.ToolbarProgressBar	73 <org.chromium.chrome.browser.widget.ToolbarProgressBar

73 android:id="@+id/progress"	74 android:id="@+id/progress"

74 style="@style/Widget.AppCompat.ProgressBar.Horizontal"	75 style="@style/Widget.AppCompat.ProgressBar.Horizontal"

75 android:progressDrawable="@drawable/progress_bar"	76 android:progressDrawable="@drawable/progress_bar"

76 android:layout_width="match_parent"	77 android:layout_width="match_parent"

77 android:layout_height="2dp"	78 android:layout_height="2dp"

78 android:progress="0" />	79 android:progress="0" />

79 </org.chromium.chrome.browser.toolbar.CustomTabToolbar>	80 </org.chromium.chrome.browser.toolbar.CustomTabToolbar>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | no next file with comments »