src/IceTargetLoweringX8632Traits.h - Issue 1221643012: Subzero: Add -Wshadow to the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632Traits.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringX8632Traits.h

diff --git a/src/IceTargetLoweringX8632Traits.h b/src/IceTargetLoweringX8632Traits.h

index ae9abe1e6627784476fa81238d19b5d1f3573522..8528ee72cfd6a3ab8c03981480f8a2355a3c7642 100644

--- a/src/IceTargetLoweringX8632Traits.h

+++ b/src/IceTargetLoweringX8632Traits.h

@@ -627,8 +627,8 @@ template <> struct MachineTraits<TargetX8632> {

}

private:

- VariableSplit(Cfg *Func, Variable *Var, Portion Part)

- : X86Operand(kSplit, IceType_i32), Var(Var), Part(Part) {

+ VariableSplit(Cfg *Func, Variable *MyVar, Portion MyPart)

+ : X86Operand(kSplit, IceType_i32), Var(MyVar), Part(MyPart) {

assert(Var->getType() == IceType_f64);

Vars = Func->allocateArrayOf<Variable *>(1);

Vars[0] = Var;