src/IceDefs.h - Issue 1221643012: Subzero: Add -Wshadow to the build. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1792)

My Issues | Starred Open | Closed | All

Unified Diff: src/IceDefs.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Change the previous underscore naming style Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« Makefile.standalone ('K') | « src/IceConverter.cpp ('k') | src/IceELFObjectWriter.cpp » ('j') | src/IceInst.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/IceDefs.h

diff --git a/src/IceDefs.h b/src/IceDefs.h

index 2ee41a72bf8a9790d08cb7d8c3af17eba31452b0..e114402ab74fb5ecf5179ea29f60d428768be6af 100644

--- a/src/IceDefs.h

+++ b/src/IceDefs.h

@@ -18,6 +18,9 @@

#include "IceBuildDefs.h" // TODO(stichnot): move into individual files

#include "IceTLS.h"

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wunused-parameter"

+#pragma clang diagnostic ignored "-Wshadow"

#include "llvm/ADT/ArrayRef.h"

#include "llvm/ADT/BitVector.h"

#include "llvm/ADT/ilist.h"

@@ -30,6 +33,7 @@

#include "llvm/Support/Casting.h"

#include "llvm/Support/ELF.h"

#include "llvm/Support/raw_ostream.h"

+#pragma clang diagnostic pop

#include <cassert>

#include <cstdint>

« Makefile.standalone ('K') | « src/IceConverter.cpp ('k') | src/IceELFObjectWriter.cpp » ('j') | src/IceInst.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698