Makefile.standalone - Issue 1221643012: Subzero: Add -Wshadow to the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile.standalone

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Change the previous underscore naming style Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile.standalone

diff --git a/Makefile.standalone b/Makefile.standalone

index ad8889cc91c14cb231a7764462811554c207d28c..6cd9ace2e3b46179672657109215e992939c2cca 100644

--- a/Makefile.standalone

+++ b/Makefile.standalone

@@ -162,7 +162,7 @@ SB_TRANSLATE := $(PNACL_BIN_PATH)/pnacl-translate

BASE_CXXFLAGS := -std=gnu++11 -Wall -Wextra -Werror -fno-rtti \

-fno-exceptions $(OPTLEVEL) $(ASSERTIONS) -g -pedantic \

- $(CXX_EXTRA)

+ -Wshadow $(CXX_EXTRA)

Karl 2015/07/07 17:00:40 Does '-Wshadow' need to be added to Makefile for t

Jim Stichnoth 2015/07/13 19:33:36 I meant this only for the standalone build. I don

CXXFLAGS := $(LLVM_CXXFLAGS) $(BASE_CXXFLAGS) $(CXX_DEFINES) $(HOST_FLAGS) \

$(STDLIB_FLAGS)

« no previous file with comments | « no previous file | src/IceAPInt.h » ('j') | src/IceInst.cpp » ('J')