Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceCfgNode.cpp

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Change the previous underscore naming style Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceCfgNode.cpp
diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp
index 5ff693625b2c1f60265161726a4ad85407fad6f7..e696d075f5450cf2670ee217b353a199fd3c8f3d 100644
--- a/src/IceCfgNode.cpp
+++ b/src/IceCfgNode.cpp
@@ -24,8 +24,8 @@
namespace Ice {
-CfgNode::CfgNode(Cfg *Func, SizeT LabelNumber)
- : Func(Func), Number(LabelNumber) {}
+CfgNode::CfgNode(Cfg *MyFunc, SizeT LabelNumber)
+ : Func(MyFunc), Number(LabelNumber) {}
// Returns the name the node was created with. If no name was given,
// it synthesizes a (hopefully) unique name.
@@ -882,7 +882,7 @@ void updateStats(Cfg *Func, const Inst *I) {
} // end of anonymous namespace
-void CfgNode::emit(Cfg *Func) const {
+void CfgNode::emit() const {
if (!BuildDefs::dump())
return;
Func->setCurrentNode(this);
@@ -945,9 +945,9 @@ class BundleEmitHelper {
BundleEmitHelper &operator=(const BundleEmitHelper &) = delete;
public:
- BundleEmitHelper(Assembler *Asm, TargetLowering *Target,
+ BundleEmitHelper(Assembler *MyAsm, TargetLowering *MyTarget,
const InstList &Insts)
- : Asm(Asm), Target(Target), End(Insts.end()), BundleLockStart(End),
+ : Asm(MyAsm), Target(MyTarget), End(Insts.end()), BundleLockStart(End),
BundleSize(1 << Asm->getBundleAlignLog2Bytes()),
BundleMaskLo(BundleSize - 1), BundleMaskHi(~BundleMaskLo) {}
// Check whether we're currently within a bundle_lock region.
@@ -1055,7 +1055,7 @@ private:
} // end of anonymous namespace
-void CfgNode::emitIAS(Cfg *Func) const {
+void CfgNode::emitIAS() const {
Func->setCurrentNode(this);
Assembler *Asm = Func->getAssembler<>();
// TODO(stichnot): When sandboxing, defer binding the node label
@@ -1163,7 +1163,7 @@ void CfgNode::emitIAS(Cfg *Func) const {
assert(!Retrying);
}
-void CfgNode::dump(Cfg *Func) const {
+void CfgNode::dump() const {
if (!BuildDefs::dump())
return;
Func->setCurrentNode(this);

Powered by Google App Engine
This is Rietveld 408576698