Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221553003: Use page_set_module.PageSet instead of story.StorySet (Closed)

Created:
5 years, 5 months ago by rmistry
Modified:
5 years, 5 months ago
Reviewers:
nednguyen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use page_set_module.PageSet instead of story.StorySet BUG=skia:3967 NOTRY=true TBR=nednguyen Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M tools/skp/page_sets/skia_carsvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_chalkboard_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmail_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheet_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mapsvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_nytimes_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_theverge_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_ugamsolutions_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_unicodetable_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wikipedia_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_worldjournal_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
5 years, 5 months ago (2015-06-30 12:02:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221553003/1
5 years, 5 months ago (2015-06-30 12:02:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd
5 years, 5 months ago (2015-06-30 12:03:09 UTC) #5
rmistry
5 years, 5 months ago (2015-06-30 15:22:02 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1214903008/ by rmistry@google.com.

The reason for reverting is: This should no longer be required due to Ned's fix
in https://codereview.chromium.org/1217823005/.

Powered by Google App Engine
This is Rietveld 408576698