Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221473004: The index argument for HTMLTableRowElement deleteCell() api should not be optional (Closed)

Created:
5 years, 5 months ago by shiva.jm
Modified:
5 years, 5 months ago
Reviewers:
tkent, philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The index argument for HTMLTableRowElement deleteCell() api should not be optional As per spec link: https://html.spec.whatwg.org/#the-tr-element, index argument for HTMLTableRowElement deleteCell() api should not be optional. Firefox throws TypeError:Not enough arguments, if argument is missing. IE removes the last row, while Blink/WebKit removes the first row. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M LayoutTests/fast/dom/HTMLTableRowElement/exceptions.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableRowElement/exceptions-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shiva.jm
pls have a look.
5 years, 5 months ago (2015-07-03 06:16:25 UTC) #2
philipj_slow
I'm pretty sure this will be safe, but what does "IE still gives undefined error" ...
5 years, 5 months ago (2015-07-03 21:54:16 UTC) #3
shiva.jm
On 2015/07/03 21:54:16, philipj wrote: > I'm pretty sure this will be safe, but what ...
5 years, 5 months ago (2015-07-06 04:17:10 UTC) #4
philipj_slow
Thanks, I've updated the description to reflect this.
5 years, 5 months ago (2015-07-06 07:03:58 UTC) #5
philipj_slow
lgtm
5 years, 5 months ago (2015-07-06 07:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221473004/1
5 years, 5 months ago (2015-07-06 07:04:13 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 07:56:00 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198305

Powered by Google App Engine
This is Rietveld 408576698