Source/core/html/HTMLTableRowElement.idl - Issue 1221473004: The index argument for HTMLTableRowElement deleteCell() api should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTableRowElement.idl

Issue 1221473004: The index argument for HTMLTableRowElement deleteCell() api should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTableRowElement.idl

diff --git a/Source/core/html/HTMLTableRowElement.idl b/Source/core/html/HTMLTableRowElement.idl

index d2b59dec89e82db14cd9752e0319d3753aaf2de3..bba0de5539c4898b2c3607c1eca41df7e2fd68d4 100644

--- a/Source/core/html/HTMLTableRowElement.idl

+++ b/Source/core/html/HTMLTableRowElement.idl

@@ -25,8 +25,7 @@ interface HTMLTableRowElement : HTMLElement {

readonly attribute long sectionRowIndex;

readonly attribute HTMLCollection cells;

[RaisesException] HTMLElement insertCell(optional long index = -1);

- // TODO(philipj): The index argument should not be optional.

- [RaisesException] void deleteCell([Default=Undefined] optional long index);

+ [RaisesException] void deleteCell(long index);

// obsolete members

// https://html.spec.whatwg.org/#HTMLTableRowElement-partial

« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »