Issue 1221433004: Revert of Try harder to work around a clang/win bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221433004: Revert of Try harder to work around a clang/win bug. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
jkarlin

CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Try harder to work around a clang/win bug. (patchset #1 id:1 of https://codereview.chromium.org/1208103006/) Reason for revert: Looks like this is unnecessary; the first CL did the trick already. Original issue's description: > Try harder to work around a clang/win bug. > > This is a follow-up to https://codereview.chromium.org/1215613006 > which didn't help. > > BUG=BUG=488634 > TBR=jkarlin@chromium.org TBR=jkarlin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=BUG=488634 Committed: https://crrev.com/ac24c994fa0dae5014759cf88620c303d9397655 Cr-Commit-Position: refs/heads/master@{#337338}

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	content/browser/background_sync/background_sync_registration_options.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	content/browser/background_sync/background_sync_registration_options.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

Created Revert of Try harder to work around a clang/win bug.

5 years, 5 months ago (2015-07-04 04:33:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221433004/1

5 years, 5 months ago (2015-07-04 04:33:49 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-04 04:35:09 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ac24c994fa0dae5014759cf88620c303d9397655
Cr-Commit-Position: refs/heads/master@{#337338}

Expand Messages | Collapse Messages