Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1215613006: Try to work around a clang/win bug. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to work around a clang/win bug. It (incorrectly) complains: ..\..\content/browser/background_sync/background_sync_registration_options.h(21,11) : error: cannot use defaulted default constructor of 'BackgroundSyncRegistrationOptions' within the class outside of member functions because 'min_period' has an initializer int64_t min_period = 0; ^ BUG=488634 TBR=jkarlin@chromium.org NOTRY=true Committed: https://crrev.com/f4c3e76906caa9d1fa308a30a15f48dd1f2e5a59 Cr-Commit-Position: refs/heads/master@{#337326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/background_sync/background_sync_registration_options.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_registration_options.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Nico
:-/
5 years, 5 months ago (2015-07-03 17:50:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215613006/1
5 years, 5 months ago (2015-07-03 17:50:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/74731) (exceeded global retry quota)
5 years, 5 months ago (2015-07-03 18:20:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215613006/1
5 years, 5 months ago (2015-07-03 18:22:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/74737)
5 years, 5 months ago (2015-07-03 19:29:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215613006/1
5 years, 5 months ago (2015-07-03 19:55:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 19:58:20 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 19:59:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4c3e76906caa9d1fa308a30a15f48dd1f2e5a59
Cr-Commit-Position: refs/heads/master@{#337326}

Powered by Google App Engine
This is Rietveld 408576698