Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed)

Created:
7 years, 10 months ago by gab

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, jennb, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, jianli, rdsmith+dwatch_chromium.org, sail+watch_chromium.org, Dmitry Titov, Aaron Boodman, rginda+watch_chromium.org, dcheng, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, tfarina, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Swap deprecated BrowserList:: iterators for BrowserIterator in code not compiled in WinAura builds. Hardcoding HOST_DESKTOP_TYPE where necessary. BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181887

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix compile #

Patch Set 3 : fix mac compile #

Patch Set 4 : merge up to r181832 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -56 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/app_controller_mac_browsertest.mm	View	1 2	4 chunks	+21 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/boot_times_loader.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View	1 2 3	3 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player_browsertest.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View	1 2 3	3 chunks	+5 lines, -8 lines	0 comments	Download
M	chrome/browser/download/download_status_updater_win.cc	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View	1 2 3	3 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browsertest.cc	View	1 2 3	3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/12213075/diff/1/chrome/browser/chromeos/extensions/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager_util.cc (right): https://codereview.chromium.org/12213075/diff/1/chrome/browser/chromeos/extensions/file_manager_util.cc#newcode313 chrome/browser/chromeos/extensions/file_manager_util.cc:313: for (chrome::BrowserIterator it; !it.done(); it.Next()) { nice! much cleaner ...

7 years, 10 months ago (2013-02-08 02:49:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12213075/15001

7 years, 10 months ago (2013-02-12 04:02:09 UTC) #6

Message was sent while issue was closed.

Change committed as 181887

Expand Messages | Collapse Messages