chrome/browser/chromeos/media/media_player.cc - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/media/media_player.cc

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r181832 Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager_util.cc ('k') | chrome/browser/chromeos/media/media_player_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/media/media_player.cc

diff --git a/chrome/browser/chromeos/media/media_player.cc b/chrome/browser/chromeos/media/media_player.cc

index e162c07931cd616823e871dd4f515b3b39ac7e74..d22a90e3f7ed11939581b7d559b8ee60af0b0a51 100644

--- a/chrome/browser/chromeos/media/media_player.cc

+++ b/chrome/browser/chromeos/media/media_player.cc

@@ -14,7 +14,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -153,9 +153,8 @@ GURL MediaPlayer::GetMediaPlayerUrl() {

}

Browser* MediaPlayer::GetBrowser() {

- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();

- browser_iterator != BrowserList::end(); ++browser_iterator) {

- Browser* browser = *browser_iterator;

+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {

+ Browser* browser = *it;

TabStripModel* tab_strip = browser->tab_strip_model();

for (int idx = 0; idx < tab_strip->count(); idx++) {

const GURL& url = tab_strip->GetWebContentsAt(idx)->GetURL();