src/log.cc - Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed most feedback Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 0931f920795262345cc4e3b79bd259bd0295383f..db6ae04ad3ef7833964b4bde3a705503a217b7ff 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1643,8 +1643,8 @@ void Logger::LogAccessorCallbacks() {

HeapIterator iterator;

AssertNoAllocation no_alloc;

for (HeapObject* obj = iterator.next(); obj != NULL; obj = iterator.next()) {

- if (!obj->IsAccessorInfo()) continue;

- AccessorInfo* ai = AccessorInfo::cast(obj);

+ if (!obj->IsExecutableAccessorInfo()) continue;

+ ExecutableAccessorInfo* ai = ExecutableAccessorInfo::cast(obj);

if (!ai->name()->IsString()) continue;

String* name = String::cast(ai->name());

Address getter_entry = v8::ToCData<Address>(ai->getter());

« no previous file with comments | « src/ic.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »