Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/log.cc

Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed most feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1636 } 1636 }
1637 } 1637 }
1638 1638
1639 1639
1640 void Logger::LogAccessorCallbacks() { 1640 void Logger::LogAccessorCallbacks() {
1641 HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask, 1641 HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask,
1642 "Logger::LogAccessorCallbacks"); 1642 "Logger::LogAccessorCallbacks");
1643 HeapIterator iterator; 1643 HeapIterator iterator;
1644 AssertNoAllocation no_alloc; 1644 AssertNoAllocation no_alloc;
1645 for (HeapObject* obj = iterator.next(); obj != NULL; obj = iterator.next()) { 1645 for (HeapObject* obj = iterator.next(); obj != NULL; obj = iterator.next()) {
1646 if (!obj->IsAccessorInfo()) continue; 1646 if (!obj->IsExecutableAccessorInfo()) continue;
1647 AccessorInfo* ai = AccessorInfo::cast(obj); 1647 ExecutableAccessorInfo* ai = ExecutableAccessorInfo::cast(obj);
1648 if (!ai->name()->IsString()) continue; 1648 if (!ai->name()->IsString()) continue;
1649 String* name = String::cast(ai->name()); 1649 String* name = String::cast(ai->name());
1650 Address getter_entry = v8::ToCData<Address>(ai->getter()); 1650 Address getter_entry = v8::ToCData<Address>(ai->getter());
1651 if (getter_entry != 0) { 1651 if (getter_entry != 0) {
1652 PROFILE(ISOLATE, GetterCallbackEvent(name, getter_entry)); 1652 PROFILE(ISOLATE, GetterCallbackEvent(name, getter_entry));
1653 } 1653 }
1654 Address setter_entry = v8::ToCData<Address>(ai->setter()); 1654 Address setter_entry = v8::ToCData<Address>(ai->setter());
1655 if (setter_entry != 0) { 1655 if (setter_entry != 0) {
1656 PROFILE(ISOLATE, SetterCallbackEvent(name, setter_entry)); 1656 PROFILE(ISOLATE, SetterCallbackEvent(name, setter_entry));
1657 } 1657 }
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
1813 void SamplerRegistry::RemoveActiveSampler(Sampler* sampler) { 1813 void SamplerRegistry::RemoveActiveSampler(Sampler* sampler) {
1814 ASSERT(sampler->IsActive()); 1814 ASSERT(sampler->IsActive());
1815 ScopedLock lock(active_samplers_mutex); 1815 ScopedLock lock(active_samplers_mutex);
1816 ASSERT(active_samplers_ != NULL); 1816 ASSERT(active_samplers_ != NULL);
1817 bool removed = active_samplers_->RemoveElement(sampler); 1817 bool removed = active_samplers_->RemoveElement(sampler);
1818 ASSERT(removed); 1818 ASSERT(removed);
1819 USE(removed); 1819 USE(removed);
1820 } 1820 }
1821 1821
1822 } } // namespace v8::internal 1822 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698