src/api.cc - Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed most feedback Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index d3d472d79947cd208684db88d98cc633a551f48c..d3539627e8e1153408931b4ac18a1b64aa8414a6 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1106,7 +1106,8 @@ static i::Handle<i::AccessorInfo> MakeAccessorInfo(

v8::AccessControl settings,

v8::PropertyAttribute attributes,

v8::Handle<AccessorSignature> signature) {

- i::Handle<i::AccessorInfo> obj = FACTORY->NewAccessorInfo();

+ i::Handle<i::ExecutableAccessorInfo> obj =

+ FACTORY->NewExecutableAccessorInfo();

SET_FIELD_WRAPPED(obj, set_getter, getter);

SET_FIELD_WRAPPED(obj, set_setter, setter);

if (data.IsEmpty()) data = v8::Undefined();

« no previous file with comments | « src/accessors.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »