Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: src/api.cc

Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed most feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1088 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 1099
1100 1100
1101 static i::Handle<i::AccessorInfo> MakeAccessorInfo( 1101 static i::Handle<i::AccessorInfo> MakeAccessorInfo(
1102 v8::Handle<String> name, 1102 v8::Handle<String> name,
1103 AccessorGetter getter, 1103 AccessorGetter getter,
1104 AccessorSetter setter, 1104 AccessorSetter setter,
1105 v8::Handle<Value> data, 1105 v8::Handle<Value> data,
1106 v8::AccessControl settings, 1106 v8::AccessControl settings,
1107 v8::PropertyAttribute attributes, 1107 v8::PropertyAttribute attributes,
1108 v8::Handle<AccessorSignature> signature) { 1108 v8::Handle<AccessorSignature> signature) {
1109 i::Handle<i::AccessorInfo> obj = FACTORY->NewAccessorInfo(); 1109 i::Handle<i::ExecutableAccessorInfo> obj =
1110 FACTORY->NewExecutableAccessorInfo();
1110 SET_FIELD_WRAPPED(obj, set_getter, getter); 1111 SET_FIELD_WRAPPED(obj, set_getter, getter);
1111 SET_FIELD_WRAPPED(obj, set_setter, setter); 1112 SET_FIELD_WRAPPED(obj, set_setter, setter);
1112 if (data.IsEmpty()) data = v8::Undefined(); 1113 if (data.IsEmpty()) data = v8::Undefined();
1113 obj->set_data(*Utils::OpenHandle(*data)); 1114 obj->set_data(*Utils::OpenHandle(*data));
1114 obj->set_name(*Utils::OpenHandle(*name)); 1115 obj->set_name(*Utils::OpenHandle(*name));
1115 if (settings & ALL_CAN_READ) obj->set_all_can_read(true); 1116 if (settings & ALL_CAN_READ) obj->set_all_can_read(true);
1116 if (settings & ALL_CAN_WRITE) obj->set_all_can_write(true); 1117 if (settings & ALL_CAN_WRITE) obj->set_all_can_write(true);
1117 if (settings & PROHIBITS_OVERWRITING) obj->set_prohibits_overwriting(true); 1118 if (settings & PROHIBITS_OVERWRITING) obj->set_prohibits_overwriting(true);
1118 obj->set_property_attributes(static_cast<PropertyAttributes>(attributes)); 1119 obj->set_property_attributes(static_cast<PropertyAttributes>(attributes));
1119 if (!signature.IsEmpty()) { 1120 if (!signature.IsEmpty()) {
(...skipping 5575 matching lines...) Expand 10 before | Expand all | Expand 10 after
6695 6696
6696 v->VisitPointers(blocks_.first(), first_block_limit_); 6697 v->VisitPointers(blocks_.first(), first_block_limit_);
6697 6698
6698 for (int i = 1; i < blocks_.length(); i++) { 6699 for (int i = 1; i < blocks_.length(); i++) {
6699 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6700 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6700 } 6701 }
6701 } 6702 }
6702 6703
6703 6704
6704 } } // namespace v8::internal 6705 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698