chrome/browser/fast_shutdown_browsertest.cc - Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/fast_shutdown_browsertest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/fast_shutdown_browsertest.cc

diff --git a/chrome/browser/fast_shutdown_browsertest.cc b/chrome/browser/fast_shutdown_browsertest.cc

index 13d10a9c3b42b2c05f3a93aff2aa758f324e1f95..661c63a7124f4fa1b7729456df981af0133e0f1e 100644

--- a/chrome/browser/fast_shutdown_browsertest.cc

+++ b/chrome/browser/fast_shutdown_browsertest.cc

@@ -8,8 +8,8 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_iterator.h"

-#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

@@ -54,7 +54,7 @@ IN_PROC_BROWSER_TEST_F(FastShutdown, DISABLED_SlowTermination) {

window_observer.Wait();

// Close the new window, removing the one and only beforeunload handler.

- ASSERT_EQ(2u, BrowserList::size());

+ ASSERT_EQ(2u, chrome::GetTotalBrowserCount());

chrome::BrowserIterator it;

it.Next();

chrome::CloseWindow(*it);