chrome/browser/ui/cocoa/applescript/window_applescript.mm - Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/window_applescript.mm

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm ('k') | chrome/browser/ui/cocoa/panels/panel_cocoa_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/applescript/window_applescript.mm

diff --git a/chrome/browser/ui/cocoa/applescript/window_applescript.mm b/chrome/browser/ui/cocoa/applescript/window_applescript.mm

index 1f3b7bbd8f128cf10917655e4ca088574e17a8b3..443607584fe09b5741d4165ef8b4583120c17d79 100644

--- a/chrome/browser/ui/cocoa/applescript/window_applescript.mm

+++ b/chrome/browser/ui/cocoa/applescript/window_applescript.mm

@@ -13,7 +13,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_window.h"

@@ -212,7 +212,7 @@

- (void)setOrderedIndex:(NSNumber*)anIndex {

int index = [anIndex intValue] - 1;

- if (index < 0 || index >= (int)BrowserList::size()) {

+ if (index < 0 || index >= (int)chrome::GetTotalBrowserCount())) {

sky 2013/02/12 00:44:52 static_cast (I think for .mm files too)

gab 2013/02/12 03:53:52 Done.

AppleScript::SetError(AppleScript::errWrongIndex);

return;

}