chrome/browser/browser_commands_unittest.cc - Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/browser_process_impl.cc » ('j') | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_commands_unittest.cc

diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc

index 15155a8357aea54b628586fefb72827a8293ce07..1422469a877d386e90b5ccae133a66f79373b37b 100644

--- a/chrome/browser/browser_commands_unittest.cc

+++ b/chrome/browser/browser_commands_unittest.cc

@@ -7,7 +7,7 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/ui/browser_command_controller.h"

#include "chrome/browser/ui/browser_commands.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/browser_with_test_window_test.h"

@@ -76,13 +76,13 @@ TEST_F(BrowserCommandsTest, DuplicateTab) {

EXPECT_EQ(3, orig_controller.GetEntryCount());

EXPECT_TRUE(orig_controller.GetPendingEntry());

- size_t initial_window_count = BrowserList::size();

+ size_t initial_window_count = chrome::GetTotalBrowserCount();

// Duplicate the tab.

chrome::ExecuteCommand(browser(), IDC_DUPLICATE_TAB);

// The duplicated tab should not end up in a new window.

- size_t window_count = BrowserList::size();

+ size_t window_count = chrome::GetTotalBrowserCount();

ASSERT_EQ(initial_window_count, window_count);

// And we should have a newly duplicated tab.

@@ -113,13 +113,13 @@ TEST_F(BrowserCommandsTest, ViewSource) {

EXPECT_EQ(1, orig_controller.GetEntryCount());