Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 1221193004: Bindings: visitDOMWrapper should not create a new wrapper (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 {% block visit_dom_wrapper %} 557 {% block visit_dom_wrapper %}
558 {% if set_wrapper_reference_from or set_wrapper_reference_to %} 558 {% if set_wrapper_reference_from or set_wrapper_reference_to %}
559 void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script Wrappable, const v8::Persistent<v8::Object>& wrapper) 559 void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script Wrappable, const v8::Persistent<v8::Object>& wrapper)
560 { 560 {
561 {{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>(); 561 {{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();
562 {% if set_wrapper_reference_to %} 562 {% if set_wrapper_reference_to %}
563 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper); 563 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
564 V8WrapperInstantiationScope scope(creationContext, isolate); 564 V8WrapperInstantiationScope scope(creationContext, isolate);
565 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}(); 565 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}();
566 if ({{set_wrapper_reference_to.name}}) { 566 if ({{set_wrapper_reference_to.name}}) {
567 if (!DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, is olate)) 567 if (DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, iso late))
568 {{set_wrapper_reference_to.name}}->wrap(isolate, creationContext); 568 DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_t o.name}}, isolate);
569 DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.na me}}, isolate);
570 } 569 }
571 {% endif %} 570 {% endif %}
572 {% if set_wrapper_reference_from %} 571 {% if set_wrapper_reference_from %}
573 // The {{set_wrapper_reference_from}}() method may return a reference or a p ointer. 572 // The {{set_wrapper_reference_from}}() method may return a reference or a p ointer.
574 if (Node* owner = WTF::getPtr(impl->{{set_wrapper_reference_from}}())) { 573 if (Node* owner = WTF::getPtr(impl->{{set_wrapper_reference_from}}())) {
575 Node* root = V8GCController::opaqueRootForGC(isolate, owner); 574 Node* root = V8GCController::opaqueRootForGC(isolate, owner);
576 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 575 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
577 return; 576 return;
578 } 577 }
579 {% endif %} 578 {% endif %}
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 } 957 }
959 958
960 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 959 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
961 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 960 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
962 { 961 {
963 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 962 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
964 } 963 }
965 {% endfor %} 964 {% endfor %}
966 {% endif %} 965 {% endif %}
967 {% endblock %} 966 {% endblock %}
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698