[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
index c899d04d9aafa5ba44b534c5867730a158751f6f..a4763408aaa5c7e20c99c47a9532c5c982f256a6 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
@@ -393,6 +393,10 @@ void ToolbarActionsBarBridge::ShowExtensionMessageBubble(
   return self;
 }
 
+- (void)browserWillBeDestroyed {

[tapted, 2015/07/06 07:26:18]

after dealloc

[jackhou1, 2015/07/07 03:27:27]

Done.

+  browser_ = nullptr;
+}

[tapted, 2015/07/06 07:26:18]

hm - toolbarActionsBar_ has a weak reference to Browser* as well.

I'm actually now thinking we should scrap all the dealloc methods, and replace
them with browserWillBeDestroyed (and, at the end, do the browser_ = nullptr).

[jackhou1, 2015/07/07 03:27:27]

Done in patch set 7.

+
 - (void)dealloc {
   // Explicitly destroy the ToolbarActionsBar so all buttons get removed with a
   // valid BrowserActionsController, and so we can verify state before