[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <string>
 
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
@@ skipping 375 matching lines @@
                  name:kBrowserActionsContainerMouseEntered
                object:containerView_];
     }
 
     focusedViewIndex_ = -1;
   }
 
   return self;
 }
 
+- (void)browserWillBeDestroyed {

[tapted, 2015/07/06 07:26:18]

after dealloc

[jackhou1, 2015/07/07 03:27:27]

Done.

+  browser_ = nullptr;
+}

[tapted, 2015/07/06 07:26:18]

hm - toolbarActionsBar_ has a weak reference to Browser* as well.

I'm actually now thinking we should scrap all the dealloc methods, and replace
them with browserWillBeDestroyed (and, at the end, do the browser_ = nullptr).

[jackhou1, 2015/07/07 03:27:27]

Done in patch set 7.

+
 - (void)dealloc {
   // Explicitly destroy the ToolbarActionsBar so all buttons get removed with a
   // valid BrowserActionsController, and so we can verify state before
   // destruction.
   toolbarActionsBar_->DeleteActions();
   toolbarActionsBar_.reset();
   DCHECK_EQ(0u, [buttons_ count]);
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super dealloc];
 }
@@ skipping 621 matching lines @@
 }
 
 #pragma mark -
 #pragma mark Testing Methods
 
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index {
   return index < [buttons_ count] ? [buttons_ objectAtIndex:index] : nil;
 }
 
 @end